fix(markdown): add margins to all markdown elements #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
vsgoulart
approved these changes
Jan 15, 2024
There was a problem hiding this comment.
Code wise everything looks good
@douglasbouttell-camunda I just need to talk about the visual regression tests with you tomorrow
Skaiir
approved these changes
Jan 16, 2024
There was a problem hiding this comment.
Looks good on my end, besides the visual regression stuff :)
Ah right actually @douglasbouttell-camunda you also need to sign the CLA when working on bpmn-io repos, shouldn't be a complex process. You just need to do it once.
|
Feel free to merge @douglasbouttell-camunda :) |
vsgoulart
pushed a commit
that referenced
this pull request
Jan 19, 2024
vsgoulart
added a commit
that referenced
this pull request
Jan 31, 2024
* chore: update actions/setup-node digest to d86ebcd (#967) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(markdown): add margins to all markdown elements (#986) * fix: improve image editor placeholder styles Related to #994 * chore: adjust iframe placeholder font size Related to #994 * feat: add `security` properties for iFrame Closes #901 * feat: add warning step to iframe security attributes config Related to #901 * fix: show iframe title in the editor Closes #990 * chore(CHANGELOG): correct minor formatting issues (#1003) * chore: update actions/cache action to v4 (#995) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: update actions/upload-artifact digest to 26f96df (#979) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix: repeatable entry parameters now validate with errors Closes #966 * feat: implement number field debouncing Closes #958 * chore: remove superfluous useEffects Related to #958 * fix: Prevent demo data from being created on edited tables Closes #997 * chore: Add experimental tag Related to #997 * chore: update actions/upload-artifact digest to d00351b (#1014) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat: implement HTML display component Closes #1004 * feat(schema): support HTML component Related to #1004 * chore: remove our dependency on preact-markup Related to #1004 * fix: limit cm-editor properties height to 400px Related to #1004 * chore: cleanup html and text components Related to #1004 * fix: handle native CSS scoping & added tests #1004 * chore: updated snapshots * chore: Update deps (#1008) * chore: Update deps * chore: Revert properties panel update * chore: update dependency source-map-loader to v5 (#988) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: replace dependency npm-run-all with npm-run-all2 ^5.0.0 (#1012) * chore: replace dependency npm-run-all with npm-run-all2 ^5.0.0 * chore: Update to 6.1.1 --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Vinicius Goulart <[email protected]> * fix: resize textarea on input changes (#1017) Closes #1011 --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: bpmn-io-bot <[email protected]> Co-authored-by: Douglas Bouttell <[email protected]> Co-authored-by: Vinicius Goulart <[email protected]> Co-authored-by: Niklas Kiefer <[email protected]> Co-authored-by: Nico Rehwaldt <[email protected]> Co-authored-by: Skaiir <[email protected]>
Skaiir
pushed a commit
that referenced
this pull request
Jan 31, 2024
Skaiir
pushed a commit
that referenced
this pull request
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/camunda/product-hub/issues/2024
form-jselement or visually changes an existing component.Screenshot